replace more asserts with exception checks in tests

This commit is contained in:
Thomas Rubini 2023-01-05 15:32:39 +01:00
parent 824190348d
commit 9829f13743
No known key found for this signature in database
GPG Key ID: C7D287C8C1CAC373

View File

@ -139,7 +139,8 @@ def test_that_two_person_can_join_a_game():
def test_that_people_cant_join_if_the_username_is_already_used(): def test_that_people_cant_join_if_the_username_is_already_used():
game_id = createGame(User("neoreille")) game_id = createGame(User("neoreille"))
joinGame(User("neosomse"),game_id) joinGame(User("neosomse"),game_id)
assert joinGame(User("neosomse"),game_id) == False with pytest.raises(TestException) as e:
joinGame(User("neosomse"),game_id)
def test_that_people_joining_without_sending_any_data_results_in_an_error(): def test_that_people_joining_without_sending_any_data_results_in_an_error():
game_id = createGame(User("neoxyde")) game_id = createGame(User("neoxyde"))
@ -163,17 +164,23 @@ def test_that_people_joining_without_sending_an_username_still_results_in_an_err
def test_that_people_joining_with_an_empty_username_still_results_in_an_error(): def test_that_people_joining_with_an_empty_username_still_results_in_an_error():
game_id = createGame(User("neodeur")) game_id = createGame(User("neodeur"))
user = User("") user = User("")
assert joinGame(user,game_id) == False
with pytest.raises(TestException) as e:
joinGame(user,game_id)
def test_that_people_joining_aving_an_username_that_contains_non_alphanumerics_still_results_in_an_error(): def test_that_people_joining_aving_an_username_that_contains_non_alphanumerics_still_results_in_an_error():
game_id = createGame(User("neobservateur")) game_id = createGame(User("neobservateur"))
user = User("Я брат русского пирата") user = User("Я брат русского пирата")
assert joinGame(user,game_id) == False
with pytest.raises(TestException) as e:
joinGame(user,game_id)
def test_that_people_joining_aving_a_too_long_username_still_results_in_an_error(): def test_that_people_joining_aving_a_too_long_username_still_results_in_an_error():
game_id = createGame(User("neordre")) game_id = createGame(User("neordre"))
user = User("Les tests unitaires sont généralement effectués pendant la phase de développement des applications mobiles ou logicielles. Ces tests sont normalement effectués par les développeurs, bien quà toutes fins pratiques, ils puissent également être effectués par les responsables en assurance QA.") user = User("Les tests unitaires sont généralement effectués pendant la phase de développement des applications mobiles ou logicielles. Ces tests sont normalement effectués par les développeurs, bien quà toutes fins pratiques, ils puissent également être effectués par les responsables en assurance QA.")
assert joinGame(user,game_id) == False
with pytest.raises(TestException) as e:
joinGame(user,game_id)
############################################################################### ###############################################################################
@ -192,21 +199,18 @@ def test_that_people_joining_aving_a_too_long_username_still_results_in_an_error
def test_that_people_can_start_a_game(): def test_that_people_can_start_a_game():
owner = User("neAUBERGINE") owner = User("neAUBERGINE")
game_id = createGame(owner) game_id = createGame(owner)
assert startGame(owner) == True startGame(owner)
def test_that_a_started_game_cannot_be_started_again(): def test_that_a_started_game_cannot_be_started_again():
owner = User("neosteopathie")
game_id = createGame(owner)
with pytest.raises(TestException) as e: with pytest.raises(TestException) as e:
owner = User("neosteopathie")
game_id = createGame(owner)
startGame(owner) startGame(owner)
assert "Status is not ok" in str(e.value)
def test_that_non_owners_cant_start_a_game(): def test_that_non_owners_cant_start_a_game():
with pytest.raises(TestException) as e: owner = User("neosteopathie")
owner = User("neosteopathie") notOwner = User("neorphelin")
notOwner = User("neorphelin") game_id = createGame(owner)
game_id = createGame(owner) joinGame(notOwner,game_id)
joinGame(notOwner,game_id) with pytest.raises(TestException) as e:
assert startGame(notOwner) == False startGame(notOwner)
assert "Status is not ok" in str(e.value)