DjalimSimaila/PackageViewer
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

add return statements to future after .complete()

Browse Source
This commit is contained in:
Thomas Rubini 2022-12-12 22:45:48 +01:00
parent c4901e80ce
commit 61830e93f5
No known key found for this signature in database
GPG Key ID: C7D287C8C1CAC373
1 changed files with 22 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
src/main/java/fr/packageviewer/distribution/ArchDistribution.java
View File

@ -107,6 +107,7 @@ public class ArchDistribution implements Distribution {
// unknown package, probably an abstract dependency // unknown package, probably an abstract dependency
logger.fine("Completing callback INVALID for package %s (depth=%s)".formatted(packageName, depth)); logger.fine("Completing callback INVALID for package %s (depth=%s)".formatted(packageName, depth));
futurePackage.complete(null); futurePackage.complete(null);
return;
} }
JSONObject resultJson = json.getJSONArray("results").getJSONObject(0); JSONObject resultJson = json.getJSONArray("results").getJSONObject(0);
@ -117,30 +118,30 @@ public class ArchDistribution implements Distribution {
description = resultJson.getString("pkgdesc"); description = resultJson.getString("pkgdesc");
// if we're at the maximum depth, return the package without its dependencies // if we're at the maximum depth, return the package without its dependencies
if(depth==0){ if(depth==0) {
logger.fine("Completing callback NODEP for package %s (depth=%s)".formatted(packageName, depth)); logger.fine("Completing callback NODEP for package %s (depth=%s)".formatted(packageName, depth));
futurePackage.complete(new Package(name, version, repo, description, Collections.emptyList())); futurePackage.complete(new Package(name, version, repo, description, Collections.emptyList()));
} else { return;
// iterate for every package in the list
List<CompletableFuture<Package>> futureDeps = new ArrayList<>();
for (Object depPackageNameObj : resultJson.getJSONArray("depends")) {
// convert object into String
String depPackageName = (String) depPackageNameObj;
// add package into Package List
futureDeps.add(getPackageTree(depPackageName, depth - 1));
}
for(CompletableFuture<Package> future : futureDeps){
try {
deps.add(future.get());
} catch (InterruptedException | ExecutionException e) {
throw new RuntimeException(e);
}
}
// TODO this doesn't seem clean
logger.fine("Completing callback DEPS for package %s (depth=%s)".formatted(packageName, depth));
futurePackage.complete(new Package(name, version, repo, description, deps));
} }
// iterate for every package in the list
List<CompletableFuture<Package>> futureDeps = new ArrayList<>();
for (Object depPackageNameObj : resultJson.getJSONArray("depends")) {
// convert object into String
String depPackageName = (String) depPackageNameObj;
// add package into Package List
futureDeps.add(getPackageTree(depPackageName, depth - 1));
}
for(CompletableFuture<Package> future : futureDeps){
try {
deps.add(future.get());
} catch (InterruptedException | ExecutionException e) {
throw new RuntimeException(e);
}
}
// TODO this doesn't seem clean
logger.fine("Completing callback DEPS for package %s (depth=%s)".formatted(packageName, depth));
futurePackage.complete(new Package(name, version, repo, description, deps));
}).exceptionally((e2->{ }).exceptionally((e2->{
logger.warning("Error while fetching package %s (depth=%s) from the API : \n%s".formatted(packageName, depth, e2)); logger.warning("Error while fetching package %s (depth=%s) from the API : \n%s".formatted(packageName, depth, e2));
e2.printStackTrace(); e2.printStackTrace();